-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpld_gridgen - Update regression tests to run in parallel #1027
Draft
GeorgeGayno-NOAA
wants to merge
25
commits into
ufs-community:develop
Choose a base branch
from
GeorgeGayno-NOAA:cpldg_tests
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
cpld_gridgen - Update regression tests to run in parallel #1027
GeorgeGayno-NOAA
wants to merge
25
commits into
ufs-community:develop
from
GeorgeGayno-NOAA:cpldg_tests
+373
−326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the remove of some log files from scripts. Fixes ufs-community#1016.
@DeniseWorthen - I would like you to review this. No hurry. The overall functionality is unchanged. |
I still have some final cleanup to do. |
Oh that's great! I'll take a look when I've got a chance. |
as this is not used in OPS. Fixes ufs-community#1016.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Currently, each regression test runs in sequence. These updates submit all tests to the batch queue at once, where they run independently. Then, when they are finished, a 'summary' job is triggered to create some final log files, check for errors and create a "summary" log. All other functions, such as options to build the executable (
rt.sh -b
), create a new baseline (rt.sh -c
) and test against the new baseline (rt.sh -m
) are retained.Some specifics:
check_results
function was moved fromrt.sh
to./ush/cpld_gridgen.sh
rt_summary.sh
is called fromrt.sh
. It checks for errors, concatenates the log files from the individual tests to a final log file, checks for errors and creates a summary file.exports
from the scripts.TESTS CONDUCTED:
If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.
Optional test.
Describe any additional tests performed.
DEPENDENCIES:
None.
DOCUMENTATION:
All new and updated source code must be documented with Doxygen.
If this PR is contributing new capabilities that need to be documented, please also include updates to the RST files in the docs/source directory as supporting material.
ISSUE:
Fixes #1016.