Add a language level option for parsing #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thought here. Since we have already released a version of the annotator with the default language level as 17, switching the default to 11 would be a breaking change. Should we stick with the default level of 17 maybe? I think that would work fine in nearly all case; as of now, we only need configurability here because of javaparser/javaparser#4041. At Uber we could easily just configure the level to be 11. |
msridhar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to work around javaparser/javaparser#4041. Users impacted by that issue can set the language level to 11, assuming they are not using language constructs introduced after that version.