Actually fix archive page search error (filter by category slug, not id)

ubyssey · Feb 23, 2025 · 657f3f9 · 657f3f9
1 parent 5f06146
commit 657f3f9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/archive/models.py b/archive/models.py
@@ -318,8 +318,7 @@ def get_magazine_articles(self, request, magazine_slug):
 
 
         if CategoryPage.objects.filter(slug = magazine_slug).exists():
-            category = CategoryPage.objects.get(slug = magazine_slug)
-            articles = ArticlePage.objects.live().public().filter(category_page=category)   
+            articles = ArticlePage.objects.live().public().filter(category_page__slug=magazine_slug)   
         else:
             return render(request, '404.html', {}, status=404)
 
@@ -346,8 +345,7 @@ def get_spoof_articles(self, request, spoof_slug):
         search_query = context["q"]
 
         if CategoryPage.objects.filter(slug = spoof_slug).exists():
-            category = CategoryPage.objects.get(slug = spoof_slug)
-            articles = ArticlePage.objects.live().public().filter(category_page=category)   
+            articles = ArticlePage.objects.live().public().filter(category_page__slug=spoof_slug)   
         else:
             return render(request, '404.html', {}, status=404)
 

diff --git a/archive/templates/archive/objects/archive_filter.html b/archive/templates/archive/objects/archive_filter.html
@@ -66,10 +66,6 @@ <h2>Magazines <a href="#" class="filterDropdown"><ion-icon name="caret-down-outl
                 </li>
                 {% endif %}
             {% endfor %}
-            <li
-                class="o-archive__sidebar__filter{% if section_slug == "magazine" %} o-archive__sidebar__filter--is-active{% endif %}">
-                <a href="{% pageurl self %}magazines/{{ request|query_string }}">All magazines</a>
-            </li>
             {% for iter in self.magazines_filters.all %}
                 {% if iter.magazine_filter.slug != magazine_slug %}
                 <li