fix: peer sharing agency is theirs error #33
+40
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
receiving Message::SharePeers(Vec<PeerAddress>)
State::Busy
toState::Idle
peer sharing client
cannot properly decode the intended message that it should receive.State::Busy
send_share_request(amount)
andrecv_peer_addresses()
again and again.State::Busy
agency is theirs
error will occur because in order for us to dosend_share_request(amount)
again, we need to be onState::Idle
Fix
has_agency()
function of Pallas' peersharing mini-protocol clientsend_share_request(amount)
andrecv_peer_addresses()
again and again.is_peer_sharing_enabled
field to false so that it won't try to discover peers againOther adjustments