fix: finish resolving audit findings: AST-001, AST-301, AST-302 and AST-303 #113

francolq · 2025-02-20T22:03:53Z

NOTE: this PR is marked as draft because it is stacked on top of PR #112

Resolve AST-001 "Leaking admin tokens":

Solve for Asteria UTxO by checking that all value without lovelace is still locked into the Asteria UTxO.
Solve for pellet UTxOs in Provide redeemer by checking the complete pellet output value.

Finish resolving AST-302 "Crowded shipyard":

Move all possible checks from spacetime.ak:spend():MineAsteria to asteria.ak:spend():Mine.
Move all possible checks from spacetime.ak:spend():GatherFuel to pellet.ak:spend():Provide(amount).
Some checks are refactored to improve legibility.

Resolve AST-303: simplify MinFuel.

Resolve AST-301: remove ScriptAddress type and directly use Aiken's ScriptHash.

…time to asteria

…er, in spacetime mine check for exactly one valid asteria input

… (also add code comments)

…validator tests

…ST-302

…bit refactored): ship input state, minting, validity range, etc.

…to pellets, and refactor remaining checks about the ship output: now the fuel can come from any external source

…etime GatherFuel tests

… anymore

…s the other redeemers

…ing Aiken's ScriptHash

francolq added 15 commits February 28, 2025 20:04

fix: refactor checks in mine asteria, preparing for fixing AST-302

a0e67ab

fix: in mine asteria move checks about mint and ship state from space…

b203b8e

…time to asteria

fix: in asteria mine check for ship input address

12392ac

fix: in spacetime mine check for correct asteria purpose and redeemer

05d6945

in asteria mine check for exactly one valid ship input and its redeem…

4df44b5

…er, in spacetime mine check for exactly one valid asteria input

fix: in asteria mine do not enforce emtpy staking address for asteria…

f09ac9b

… (also add code comments)

test: fix mine tests, moving failure tests from spaceship to asteria …

1c10548

…validator tests

fix: also in shipyard mint check for unique asteria input

6c84f65

fix: in pellets resolve AST-001 and refactor checks towards solving A…

d5bbdfe

…ST-302

fix: AST-302 - in pellets Provide add checks taken from spacetime (a …

1169a5a

…bit refactored): ship input state, minting, validity range, etc.

fix: AST-302 - in spacetime GatherFuel, remove all validations moved …

4c72ca3

…to pellets, and refactor remaining checks about the ship output: now the fuel can come from any external source

test: fix pellet Provide tests, add new failing tests taken from spac…

5b1c13b

…etime GatherFuel tests

test: fix spacetime GatherFuel tests, remove tests that doesn't apply…

2496e80

… anymore

fix: AST-302 - wrap up by refactoring MoveShip to follow same style a…

d28841a

…s the other redeemers

fix: AST303 - resolve by simplifying MinFuel

4152299

francolq force-pushed the fix/onchain2 branch from 8ac63df to 4152299 Compare February 28, 2025 23:12

francolq added 4 commits February 28, 2025 20:23

fix: AST-301 - resolve by removing ScriptAddress type and directly us…

cf28987

…ing Aiken's ScriptHash

test: last test fixes

1af4f18

style: minor style fix

5a37c5c

chore: update Aiken generated plutus blueprints

cf0f14c

francolq changed the title ~~(draft) fix: progress resolving audit findings AST-001 and AST-302 for "mine" operation~~ fix: finish resolving audit findings: AST-001, AST-301, AST-302 and AST-303 Feb 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: finish resolving audit findings: AST-001, AST-301, AST-302 and AST-303 #113

fix: finish resolving audit findings: AST-001, AST-301, AST-302 and AST-303 #113

francolq commented Feb 20, 2025 •

edited

Loading

fix: finish resolving audit findings: AST-001, AST-301, AST-302 and AST-303 #113

Are you sure you want to change the base?

fix: finish resolving audit findings: AST-001, AST-301, AST-302 and AST-303 #113

Conversation

francolq commented Feb 20, 2025 • edited Loading

francolq commented Feb 20, 2025 •

edited

Loading