Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rank inference for tan #2868

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Add rank inference for tan #2868

merged 1 commit into from
Mar 4, 2025

Conversation

Msa360
Copy link
Contributor

@Msa360 Msa360 commented Mar 4, 2025

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

#2854

Changes

Tan doesn't change the shape, to the output shape is the same as input shape.

Testing

No tests needed.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, missed that in the previous review 🤦

Thanks for the quick fix!

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.30%. Comparing base (a6b5210) to head (92445e7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2868   +/-   ##
=======================================
  Coverage   82.30%   82.30%           
=======================================
  Files         863      863           
  Lines      116968   116969    +1     
=======================================
+ Hits        96268    96269    +1     
  Misses      20700    20700           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laggui laggui merged commit 1cf6d22 into tracel-ai:main Mar 4, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants