-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/quant/per block #2849
Merged
Merged
Feat/quant/per block #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2849 +/- ##
==========================================
+ Coverage 82.18% 82.29% +0.11%
==========================================
Files 854 861 +7
Lines 114059 116887 +2828
==========================================
+ Hits 93734 96194 +2460
- Misses 20325 20693 +368 ☔ View full report in Codecov by Sentry. |
4a083fa
to
08a4b7f
Compare
08a4b7f
to
a7bf68b
Compare
nathanielsimard
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks all
script has been executed.Changes
More quantization granularity!
QuantizationScheme
enumCalibration
to an enumQuantizationStrategy
)[offset_1, offset_2, ..., offset_num_blocks, scale_1, scale_2, ..., scale_num_blocks]
(with offsets being optional)Test utils:
#[might_panic]
test attribute (for ops configuration that are not strictly required, e.g. different quantization schemes)For the CI:
No space left on device
issues).Testing
Unit tests for new schemes