Improve pickle (CandleTensor) conversions to NestedValue #1944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
Fixes #1773
Changes
Testing
Here are time improvements:
Old version:
cargo run --bin convert --release
0.98s user 0.11s system 89% cpu 1.217 total
cargo run --bin convert (DEBUG)
12.21s user 0.14s system 88% cpu 13.960 total
New version:
cargo run --bin convert --release
0.68s user 0.10s system 86% cpu 0.903 total
cargo run --bin convert (DEBUG)
9.19s user 0.14s system 85% cpu 10.943 total
44% improvement for the release mode.