-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fusion] Support multi-precision fusion #1718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Man, I need another coffee after looking at all this code ☕
Overall, LGTM! Seems to have really simplified things to move the types to the runtime.
Only have two minor comments below.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1718 +/- ##
========================================
Coverage 86.42% 86.42%
========================================
Files 699 697 -2
Lines 81839 82645 +806
========================================
+ Hits 70729 71429 +700
- Misses 11110 11216 +106 ☔ View full report in Codecov by Sentry. |
Checklist
run-checks all
script has been executed.Related Issues/PRs
Fix #1694