Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fusion] Support multi-precision fusion #1718

Merged
merged 27 commits into from
May 2, 2024
Merged

Conversation

nathanielsimard
Copy link
Member

@nathanielsimard nathanielsimard commented May 1, 2024

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Fix #1694

@nathanielsimard nathanielsimard requested a review from laggui May 1, 2024 11:54
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, I need another coffee after looking at all this code ☕

Overall, LGTM! Seems to have really simplified things to move the types to the runtime.

Only have two minor comments below.

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 87.71084% with 204 lines in your changes are missing coverage. Please review.

Project coverage is 86.42%. Comparing base (2e4c82f) to head (97a2c4f).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/burn-fusion/src/ops/int.rs 90.13% 37 Missing ⚠️
crates/burn-fusion/src/server.rs 46.66% 24 Missing ⚠️
crates/burn-fusion/src/client/mutex.rs 55.76% 23 Missing ⚠️
crates/burn-jit/src/element.rs 0.00% 18 Missing ⚠️
crates/burn-fusion/src/ops/unary.rs 63.41% 15 Missing ⚠️
crates/burn-jit/src/fusion/base.rs 16.66% 15 Missing ⚠️
crates/burn-fusion/src/ops/float.rs 96.61% 14 Missing ⚠️
crates/burn-fusion/src/ops/binary.rs 25.00% 12 Missing ⚠️
crates/burn-fusion/src/ops/boolean.rs 90.62% 12 Missing ⚠️
crates/burn-jit/src/codegen/dialect/gpu/shader.rs 40.00% 9 Missing ⚠️
... and 8 more
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1718    +/-   ##
========================================
  Coverage   86.42%   86.42%            
========================================
  Files         699      697     -2     
  Lines       81839    82645   +806     
========================================
+ Hits        70729    71429   +700     
- Misses      11110    11216   +106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanielsimard nathanielsimard merged commit 5d959e2 into main May 2, 2024
15 checks passed
@nathanielsimard nathanielsimard deleted the fix/fusion/bridge branch May 2, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fusion] Support multi-precision fusion
3 participants