Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xtask] Add support for cargo metadata new workspace member format #1500

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

syl20bnr
Copy link
Member

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Changes

New format Introduced in Rust 1.77

Testing

Tested with both 1.76 and 1.77

@syl20bnr syl20bnr force-pushed the fix/new-workspace-member-format branch from 62eb518 to dd60d2b Compare March 21, 2024 18:46
Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syl20bnr syl20bnr force-pushed the fix/new-workspace-member-format branch from dd60d2b to 37ea8b3 Compare March 21, 2024 18:52
@syl20bnr syl20bnr force-pushed the fix/new-workspace-member-format branch from 8f6ed4d to eff6862 Compare March 21, 2024 19:18
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.79%. Comparing base (3e4af41) to head (eff6862).

Files Patch % Lines
crates/burn-fusion/src/stream/base.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1500    +/-   ##
========================================
  Coverage   85.79%   85.79%            
========================================
  Files         659      657     -2     
  Lines       74122    74022   -100     
========================================
- Hits        63590    63505    -85     
+ Misses      10532    10517    -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syl20bnr syl20bnr merged commit 0a8a3cc into main Mar 21, 2024
14 of 15 checks passed
@syl20bnr syl20bnr deleted the fix/new-workspace-member-format branch March 21, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants