Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use figment for configuration #808

Merged
merged 16 commits into from
May 9, 2024

feat: allow users not to provide config option with default values

0252f30
Select commit
Loading
Failed to load commit list.
Merged

Use figment for configuration #808

feat: allow users not to provide config option with default values
0252f30
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 9, 2024 in 1s

78.76% (-0.02%) compared to 31ab3a9

View this Pull Request on Codecov

78.76% (-0.02%) compared to 31ab3a9

Details

Codecov Report

Attention: Patch coverage is 94.62366% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 78.76%. Comparing base (31ab3a9) to head (0252f30).

Files Patch % Lines
packages/configuration/src/v1/mod.rs 94.77% 7 Missing ⚠️
packages/configuration/src/lib.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #808      +/-   ##
===========================================
- Coverage    78.78%   78.76%   -0.02%     
===========================================
  Files          163      168       +5     
  Lines         9252     9291      +39     
===========================================
+ Hits          7289     7318      +29     
- Misses        1963     1973      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.