Torrent Repository Work

[da2ce7]

This pull request is a major refactor of the torrent repository for the tracker. The code for the repository has been extracted and merged into a library package, along side it's benchmarking and testing code.

The supporting clock and time extent, and some other primitives have also been extracted, to avoid circular dependencies.

• Basic Refactors
• Selectable Torrent Repository Implementations
• Move Torrent Repository into a Package
• Use Criterion for Benchmarking Torrent Repository
• Move Clock into a Package
• Test Coverage for the Torrent Repository

[codecov]

Codecov Report

Attention: Patch coverage is 91.27590% with 80 lines in your changes are missing coverage. Please review.

Project coverage is 77.71%. Comparing base (3bd2a9c) to head (3414e2a).

Files	Patch %	Lines
packages/primitives/src/peer.rs	75.80%	15 Missing ⚠️
packages/clock/src/clock/stopped/mod.rs	84.09%	14 Missing ⚠️
packages/primitives/src/announce_event.rs	33.33%	10 Missing ⚠️
packages/primitives/src/info_hash.rs	92.30%	7 Missing ⚠️
packages/primitives/src/torrent_metrics.rs	45.45%	6 Missing ⚠️
src/core/mod.rs	92.00%	4 Missing ⚠️
src/lib.rs	75.00%	4 Missing ⚠️
packages/clock/src/clock/working/mod.rs	50.00%	3 Missing ⚠️
packages/configuration/src/lib.rs	25.00%	3 Missing ⚠️
src/servers/http/v1/handlers/announce.rs	76.92%	3 Missing ⚠️
... and 8 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #690      +/-   ##
===========================================
+ Coverage    74.06%   77.71%   +3.64%     
===========================================
  Files          145      158      +13     
  Lines         8958     8711     -247     
===========================================
+ Hits          6635     6770     +135     
+ Misses        2323     1941     -382     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[josecelano]

Hi @da2ce7

This is a lot of work and it was needed. Just a couple of generic comments:

1. You could have created at least 3 different PRs: two of them to extract the new packages (clock and torrent-repository-xx) and another one for the rest (primitives). Just to avoid wasting time merging potential conflicts. For example, merging this PR before this one.
2. There are things I would move to independent repos. Basically, the things that can be used in other repos not only the tracker.

• clock. See: https://github.com/torrust/torrust-index/blob/develop/src/utils/clock.rs
• infohash. See Extract duplicate implementation of InfoHash struct torrust-index#251

But we can do that later. I've created a new issue from one of my old comments about this topic:

#753

[josecelano]

Hi @da2ce7 why didn't you move the tests also to the torrust_tracker_primitives crate?

[josecelano]

ACK 3414e2a