Add a test for global metrics with 2 HTTP trackers #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new integration test that checks that the global metrics are udapted when you run 2 HTTP trackers. Ony one metric is checked in this test. It uses fixed port that migth conflict with other running instances in the future. We should use a random free port if we run more integration tests like this in the future.
josecelano
added
Testing
now that we have a real one.
josecelano
force-pushed
the
1407-overhaul-stats-add-e2e-tests-for-the-global-metrics
branch
from
40eb09f to
4e59dd7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1410 +/- ##
===========================================
+ Coverage 81.98% 83.13% +1.15%
===========================================
Files 232 233 +1
Lines 17011 17011
Branches 17011 17011
===========================================
+ Hits 13946 14142 +196
+ Misses 2824 2607 -217
- Partials 241 262 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
ACK b53da07 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new integration test that checks that the global metrics are updated when you run 2 HTTP trackers. Only one metric is checked in this test.
It uses fixed ports that might conflict with other running instances in the future. We should use a random free port if we run more integration tests like this in the future.
The rest of the functionality is already tested at the package level with only one tracker.
I've added to make sure nothing is broken while working on the stats overhaul.