-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul stats: start collecting stats per server instance (per socket) #1404
base: develop
Are you sure you want to change the base?
Overhaul stats: start collecting stats per server instance (per socket) #1404
Conversation
This commit creates services per HTTP tracker instances (server bound to a socket address) to collect metrics only for that instance. There should be test failing because each HTTP tracker instance can use only one event sender and metrics repository. Therefore global metrics should not be updated after this commit. I think the problem is there are no E2E tests for statistics. There are only integration tests at the HTTP Core package level. That means metrics per instance work. I will add an E2E tests for global metrics even if we are planning to remove them in the future. In the mean time, it will be covered. cc @da2ce7 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1404 +/- ##
===========================================
- Coverage 82.00% 81.83% -0.18%
===========================================
Files 232 232
Lines 17046 17082 +36
Branches 17046 17082 +36
===========================================
Hits 13979 13979
- Misses 2831 2867 +36
Partials 236 236 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It creates services per HTTP tracker instance (server bound to a socket address) to collect metrics only for that instace. There should be test failing becuase any server can use only one event sender and metrics repository. Therefore global metrics should not be updated. I think the problem is there are no E2E tests for statistics. There are only integration tests at the HTTP Core pacakge level.
42679a1
to
a9b1c14
Compare
There is another problem. You can not halt the application with CTRL+C. I think it might be a deadlock. Only the servers before the HTTP servers are started. I'm going to try a different approach. In the |
Start collecting stats per server instance (per socket).
Sub-tasks