-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul stats: Use broadcast channel for events in HTTP Core #1391
Merged
josecelano
merged 2 commits into
torrust:develop
from
josecelano:1388-overhaul-stats-use-broadcast-channel-for-events-in-http-core
Mar 18, 2025
Merged
Overhaul stats: Use broadcast channel for events in HTTP Core #1391
josecelano
merged 2 commits into
torrust:develop
from
josecelano:1388-overhaul-stats-use-broadcast-channel-for-events-in-http-core
Mar 18, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e3260a
to
c57e151
Compare
…adcast Stats events were introduced to collect tracker metrics. We only have global metrics (aggregate metrics for all UDP and HTTP trackers). This will change in the future. We will have: - Segregated metrics: one listeners per tracker (per socket). - Generic events: there could be other event consumers. Events will be decoupled from stats. This change allows multiple receivers in the channel. For now, we one use one listener but with this change will be easy to add more.
c57e151
to
5f9c4d3
Compare
ACK 5f9c4d3 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1391 +/- ##
===========================================
- Coverage 81.90% 81.88% -0.02%
===========================================
Files 232 232
Lines 17091 17081 -10
Branches 17091 17081 -10
===========================================
- Hits 13998 13987 -11
+ Misses 2842 2841 -1
- Partials 251 253 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
josecelano
added a commit
that referenced
this pull request
Mar 19, 2025
…Core d2de1de refactor: [#1389] change channel in UDP core from mpsc to broadcast (Jose Celano) Pull request description: This continues [this refactor](#1391) for the UDP core package. ACKs for top commit: josecelano: ACK d2de1de Tree-SHA512: 72ca8b7c24b691188bcecc8b2de83dec147b702621c3a340e113259131b1c023b268632894714b57ebbf84fe3147e3c6f57aa0a59a2f34d755eeaf0942d992c6
josecelano
added a commit
that referenced
this pull request
Mar 19, 2025
…Server 37c8f2b refactor: [#1390] change channel in UDP server from mpsc to broadcast (Jose Celano) Pull request description: This continues [this refactor](#1391) for the UDP core package. ACKs for top commit: josecelano: ACK 37c8f2b Tree-SHA512: ca04ef293a6eb6d172a1a7dbbbc213d165274f574d15d5e8a521aea81795f067fb785c1307a64dae69ca31d1b2f30279082ea6ad10beb2ca13771101ea9b0069
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stats events were introduced to collect tracker metrics. We only have global metrics (aggregate metrics for all UDP and HTTP trackers).
This will change in the future. We will have:
This change allows multiple receivers in the channel.
For now, we one use one listener but with this change will be easy to add more.