-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmark flow #1370
Benchmark flow #1370
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1370 +/- ##
===========================================
- Coverage 81.37% 81.28% -0.09%
===========================================
Files 229 229
Lines 16448 16519 +71
Branches 16448 16519 +71
===========================================
+ Hits 13385 13428 +43
- Misses 2821 2843 +22
- Partials 242 248 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 96c568d.
Hi @nuts-rice I have superseded this PR by #1371. I have only fixed compilation and linting errors and other minor changes. I think it's a good starting point but I have some questions:
My idea was to run it and get a number of announce requests per second with the base branch version and the new branch in the PR. And make the workflow fail if the difference was over a threshold (maybe 5%).
I would also check announce requests. I guess the problem is you have to connect before announcing. If we don't want to re-connect every X announce requests we can increase the cookie lifetime. The default value is 2 minutes. Thank you very much for your contribution! |
c155732 chore: barebones benchmarks for UDP and HTTP core packages (nuts_rice) Pull request description: This is a rework on top of #1370 It does not include moving the benchmark output report to the root dir until we implement the workflow to compare new results with the base branch results in a PR. ACKs for top commit: josecelano: ACK c155732 Tree-SHA512: cf716d71bbf5b41f94d642742ea694ae5c2ad6e9c62b3823e0ce27b3edd9f80fecd3095ef9ded91e6368e26177763d6f48239b7b023a61dcb4ac2e92c6999ab2
Superseded by #1371 |
Addresses #909 by:
cargo bench
and moving the benchmark reports to a directory accessible from root of the repohttp_tracker_core
+udp_tracker_core
the
mv
lines in the bash script are using the-b
option as i'm not sure how comparing target with PR branches should be handled.