Overhaul core Tracker: review whitelist functionality (part 2)

[josecelano]

Overhaul core Tracker: review whitelist functionality (part 2).

• Return an error in the announce handler if the tracker is running in listed mode and the infohash is not whitelisted. This is already implemented in the higher delivery layer but it should be also validated in the tracker core (domain layer).
• Change scrape handler signature to return an error even if it's not needed now. That will allow us to return an error in the future whiteout breaking changes.
• Move packages::udp_tracker_core::peer_builder::from_request to new package udp-protocol
• Inline invoke function in handlers (http-tracker-core and udp-tracker-core) when possible.

[codecov]

Codecov Report

Attention: Patch coverage is 92.47911% with 27 lines in your changes missing coverage. Please review.

Project coverage is 81.11%. Comparing base (1a5ad31) to head (d0e6936).
Report is 8 commits behind head on develop.

Files with missing lines	Patch %	Lines
packages/http-protocol/src/v1/responses/error.rs	9.09%	10 Missing ⚠️
src/packages/udp_tracker_core/services/announce.rs	68.42%	5 Missing and 1 partial ⚠️
src/servers/udp/handlers/scrape.rs	0.00%	4 Missing ⚠️
packages/http-protocol/src/v1/requests/announce.rs	57.14%	3 Missing ⚠️
packages/tracker-core/src/announce_handler.rs	98.80%	0 Missing and 1 partial ⚠️
...rc/packages/http_tracker_core/services/announce.rs	98.94%	0 Missing and 1 partial ⚠️
src/packages/http_tracker_core/services/scrape.rs	98.88%	0 Missing and 1 partial ⚠️
src/packages/udp_tracker_core/services/scrape.rs	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1274      +/-   ##
===========================================
- Coverage    81.19%   81.11%   -0.09%     
===========================================
  Files          212      212              
  Lines        14891    15015     +124     
  Branches     14891    15015     +124     
===========================================
+ Hits         12091    12179      +88     
- Misses        2603     2636      +33     
- Partials       197      200       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[josecelano]

ACK d0e6936