Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul core Tracker: extract announce handler #1208

Conversation

josecelano
Copy link
Member

Overhaul core Tracker: extract announce handler.

@josecelano josecelano added Code Cleanup / Refactoring Tidying and Making Neat - Developer - Torrust Improvement Experience labels Jan 27, 2025
@josecelano josecelano linked an issue Jan 27, 2025 that may be closed by this pull request
@josecelano josecelano requested a review from da2ce7 January 27, 2025 12:39
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 97.36842% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.68%. Comparing base (6e47314) to head (2f74caf).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
src/core/announce_handler.rs 88.04% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1208      +/-   ##
===========================================
+ Coverage    78.31%   78.68%   +0.37%     
===========================================
  Files          192      193       +1     
  Lines        13145    13341     +196     
  Branches     13145    13341     +196     
===========================================
+ Hits         10294    10497     +203     
+ Misses        2685     2679       -6     
+ Partials       166      165       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano josecelano marked this pull request as ready for review January 27, 2025 13:54
@josecelano josecelano marked this pull request as draft January 27, 2025 14:15
@josecelano josecelano force-pushed the 1207-overhaul-core-tracker-extract-announce-handler branch from 6686dcf to 2f74caf Compare January 27, 2025 14:16
@josecelano josecelano marked this pull request as ready for review January 27, 2025 15:10
@josecelano
Copy link
Member Author

ACK 2f74caf

@josecelano josecelano merged commit 5f65e16 into torrust:develop Jan 27, 2025
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overhaul core Tracker: extract announce handler
1 participant