Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul core Tracker: refactor authentication module #1196

Merged
merged 18 commits into from
Jan 22, 2025
Merged

Overhaul core Tracker: refactor authentication module #1196

merged 18 commits into from
Jan 22, 2025

Conversation

josecelano
Copy link
Member

Overhaul core Tracker: refactor authentication module.

@josecelano
refactor: [torrust#1195] create dir for mod
44255e2 
We will add more submodules.
@josecelano josecelano linked an issue Jan 21, 2025 that may be closed by this pull request
Overhaul core Tracker: refactor authentication module #1195
Closed
@josecelano josecelano self-assigned this Jan 21, 2025
@josecelano josecelano added Code Cleanup / Refactoring Tidying and Making Neat - Developer - Torrust Improvement Experience labels Jan 21, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.21642% with 31 lines in your changes missing coverage. Please review.

Project coverage is 77.86%. Comparing base (757126d) to head (dff6bca).
Report is 19 commits behind head on develop.

Files with missing lines Patch % Lines
src/core/authentication/handler.rs 83.54% 25 Missing and 1 partial ⚠️
...rc/core/authentication/key/repository/in_memory.rs 80.00% 4 Missing ⚠️
src/core/authentication/service.rs 97.77% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1196      +/-   ##
===========================================
+ Coverage    77.65%   77.86%   +0.20%     
===========================================
  Files          184      188       +4     
  Lines        12651    12811     +160     
  Branches     12651    12811     +160     
===========================================
+ Hits          9824     9975     +151     
- Misses        2662     2673      +11     
+ Partials       165      163       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano josecelano requested a review from da2ce7 January 21, 2025 17:27
@josecelano
refactor: [torrust#1195] move tests to KeysHandler
9c61b26 
These tests do not require the authentication service.
@josecelano
refactor: [torrust#1195] inject dependencies into authenticattion::Fa…
965e911 
…cade

The Facade will be replaced by its dependencies.
@josecelano
refactor: [torrust#1195] use AuthenticationService directy
747b608 
Instead of via the authentication::Facade. The Facade will be removed.
@josecelano josecelano force-pushed the 1195-overhaul-core-tracker-refactor-authentication-module branch from 3ee78bb to dff6bca Compare January 22, 2025 11:30
@josecelano josecelano marked this pull request as ready for review January 22, 2025 11:30
@josecelano
Copy link
Member Author

ACK dff6bca

@josecelano josecelano merged commit 393a6ac into torrust:develop Jan 22, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

Assignees

@josecelano josecelano

Labels
- Developer - Torrust Improvement Experience Code Cleanup / Refactoring Tidying and Making Neat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overhaul core Tracker: refactor authentication module
1 participant
@josecelano