Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spinner gif to display instead of No results while data is loading #573

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
+29 −20
Open

add spinner gif to display instead of No results while data is loading #573

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4113f0
add spinner gif to display instead of No results while data is loading
grmbyrn Jun 11, 2024
c9c5434
fixed linting errors
grmbyrn Jun 11, 2024
c807fea
change no_torrents_to_display.cy.ts to should have spinner image, not…
grmbyrn Jun 18, 2024
4bd3ad0
Merge branch 'develop' into spinner
grmbyrn Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
change no_torrents_to_display.cy.ts to should have spinner image, not… 
… No results text
@grmbyrn
grmbyrn committed Jun 18, 2024

Verified

This commit was signed with the committer’s verified signature.
grmbyrn Graeme Byrne
GPG key ID: 30D81CBA06C1FB29
Verified
Learn about vigilant mode
commit c807feab758c7443a1fcd03210b46e667ae756dd
2 changes: 1 addition & 1 deletion cypress/e2e/contexts/torrent/specs/list/no_torrents_to_display.cy.ts
View file
Original file line number Diff line number Diff line change
@@ -7,6 +7,6 @@ describe("Users", () => {
it("Should be able to see the list page when there are no torrents", () => {
cy.visit("/torrents");
cy.url().should("match", /\/torrents$/);
cy.get("[data-cy=\"no-results-element\"]").invoke("text").should("match", /No results./i);
cy.get("[data-cy=\"no-results-element\"] img").should("have.attr", "src", "/spinner.gif");
});
});