Update dependencies

Cargo.toml

@@ -35,7 +35,9 @@ once_cell = "1.13.0"
 async-trait = { version = "0.1.56", optional = true }
 futures-util = { version = "0.3.17", optional = true }
 lazy_static = { version = "1.0.2", optional = true }
-thiserror = { version = "1.0.31", optional = true }
+# Work around incorrect minimal version in opentelemetry, https://github.com/open-telemetry/opentelemetry-rust/pull/2406
+thiserror-1 = { package = "thiserror", version = "1.0.31", optional = true }
+thiserror = { version = "2", optional = true }
 smallvec = { version = "1.0", optional = true }
 
 [dev-dependencies]
@@ -54,7 +56,7 @@ tracing-error = "0.2.0"
 tracing-subscriber = { version = "0.3.0", default-features = false, features = ["registry", "std", "fmt"] }
 
 [target.'cfg(not(target_os = "windows"))'.dev-dependencies]
-pprof = { version = "0.13.0", features = ["flamegraph", "criterion"] }
+pprof = { version = "0.14.0", features = ["flamegraph", "criterion"] }
 
 [target.'cfg(all(target_arch = "wasm32", not(target_os = "wasi")))'.dependencies]
 js-sys = "0.3.64"

benches/trace.rs

@@ -3,7 +3,7 @@ use opentelemetry::{
     trace::{Span, SpanBuilder, Tracer as _, TracerProvider as _},
     Context,
 };
-use opentelemetry_sdk::trace::{Config, Tracer, TracerProvider};
+use opentelemetry_sdk::trace::{Tracer, TracerProvider};
 #[cfg(not(target_os = "windows"))]
 use pprof::criterion::{Output, PProfProfiler};
 use std::time::SystemTime;
@@ -160,10 +160,9 @@ fn many_events(c: &mut Criterion) {
     }
 
     {
-        let mut config = Config::default();
-        config.span_limits.max_events_per_span = 1000;
-
-        let provider = TracerProvider::builder().with_config(config).build();
+        let provider = TracerProvider::builder()
+            .with_max_events_per_span(1000)
+            .build();
         let tracer = provider.tracer("bench");
         let otel_layer = tracing_opentelemetry::layer()
             .with_tracer(tracer)

examples/opentelemetry-otlp.rs

@@ -63,16 +63,13 @@ fn init_tracer_provider() -> TracerProvider {
         .unwrap();
 
     TracerProvider::builder()
-        .with_config(
-            opentelemetry_sdk::trace::Config::default()
-                // Customize sampling strategy
-                .with_sampler(Sampler::ParentBased(Box::new(Sampler::TraceIdRatioBased(
-                    1.0,
-                ))))
-                // If export trace to AWS X-Ray, you can use XrayIdGenerator
-                .with_id_generator(RandomIdGenerator::default())
-                .with_resource(resource()),
-        )
+        // Customize sampling strategy
+        .with_sampler(Sampler::ParentBased(Box::new(Sampler::TraceIdRatioBased(
+            1.0,
+        ))))
+        // If export trace to AWS X-Ray, you can use XrayIdGenerator
+        .with_id_generator(RandomIdGenerator::default())
+        .with_resource(resource())
         .with_batch_exporter(exporter, runtime::Tokio)
         .build()
 }

src/layer.rs

@@ -160,7 +160,7 @@ struct SpanEventVisitor<'a, 'b> {
     sem_conv_config: SemConvConfig,
 }
 
-impl<'a, 'b> field::Visit for SpanEventVisitor<'a, 'b> {
+impl field::Visit for SpanEventVisitor<'_, '_> {
     /// Record events on the underlying OpenTelemetry [`Span`] from `bool` values.
     ///
     /// [`Span`]: opentelemetry::trace::Span
@@ -403,7 +403,7 @@ struct SpanAttributeVisitor<'a> {
     sem_conv_config: SemConvConfig,
 }
 
-impl<'a> SpanAttributeVisitor<'a> {
+impl SpanAttributeVisitor<'_> {
     fn record(&mut self, attribute: KeyValue) {
         self.span_builder_updates
             .attributes
@@ -412,7 +412,7 @@ impl<'a> SpanAttributeVisitor<'a> {
     }
 }
 
-impl<'a> field::Visit for SpanAttributeVisitor<'a> {
+impl field::Visit for SpanAttributeVisitor<'_> {
     /// Set attributes on the underlying OpenTelemetry [`Span`] from `bool` values.
     ///
     /// [`Span`]: opentelemetry::trace::Span

src/lib.rs

@@ -104,8 +104,7 @@
 //! long as doing so complies with this policy.
 //!
 //! [subscriber]: tracing_subscriber::subscribe
-#![deny(unreachable_pub)]
-#![cfg_attr(test, deny(warnings))]
+#![warn(unreachable_pub)]
 #![doc(html_root_url = "https://docs.rs/tracing-opentelemetry/0.22.0")]
 #![doc(
     html_logo_url = "https://raw.githubusercontent.com/tokio-rs/tracing/master/assets/logo-type.png",

src/metrics.rs

@@ -178,7 +178,7 @@ pub(crate) struct MetricVisitor<'a> {
     visited_metrics: &'a mut SmallVec<[(&'static str, InstrumentType); 2]>,
 }
 
-impl<'a> Visit for MetricVisitor<'a> {
+impl Visit for MetricVisitor<'_> {
     fn record_debug(&mut self, field: &Field, value: &dyn fmt::Debug) {
         self.attributes
             .push(KeyValue::new(field.name(), format!("{value:?}")));

src/tracer.rs

@@ -152,7 +152,7 @@ mod tests {
     use super::*;
     use crate::OtelData;
     use opentelemetry::trace::TracerProvider as _;
-    use opentelemetry_sdk::trace::{Config, Sampler, TracerProvider};
+    use opentelemetry_sdk::trace::{Sampler, TracerProvider};
 
     #[test]
     fn assigns_default_trace_id_if_missing() {
@@ -195,9 +195,7 @@ mod tests {
     #[test]
     fn sampled_context() {
         for (name, sampler, parent_cx, previous_sampling_result, is_sampled) in sampler_data() {
-            let provider = TracerProvider::builder()
-                .with_config(Config::default().with_sampler(sampler))
-                .build();
+            let provider = TracerProvider::builder().with_sampler(sampler).build();
             let tracer = provider.tracer("test");
             let mut builder = SpanBuilder::from_name("parent".to_string());
             builder.sampling_result = previous_sampling_result;

tests/parallel.rs

@@ -2,7 +2,7 @@ use futures_util::future::BoxFuture;
 use opentelemetry::trace::TracerProvider as _;
 use opentelemetry_sdk::{
     export::trace::{ExportResult, SpanData, SpanExporter},
-    trace::{Config, SpanLimits, Tracer, TracerProvider},
+    trace::{SpanLimits, Tracer, TracerProvider},
 };
 use std::sync::{Arc, Mutex};
 use tracing::level_filters::LevelFilter;
@@ -32,15 +32,14 @@ fn test_tracer() -> (
     impl Subscriber + Clone,
 ) {
     let exporter = TestExporter::default();
-    let mut config = Config::default();
-    config.span_limits = SpanLimits {
-        max_events_per_span: u32::MAX,
-        ..SpanLimits::default()
-    };
-
     let provider = TracerProvider::builder()
         .with_simple_exporter(exporter.clone())
-        .with_config(config)
+        // `with_max_events_per_span()` is buggy https://github.com/open-telemetry/opentelemetry-rust/pull/2405
+        .with_span_limits(SpanLimits {
+            max_events_per_span: u32::MAX,
+            ..SpanLimits::default()
+        })
+        .with_max_events_per_span(u32::MAX)
         .build();
 
     let tracer = provider.tracer("test");

tests/trace_state_propagation.rs

@@ -7,7 +7,7 @@ use opentelemetry::{
 use opentelemetry_sdk::{
     export::trace::{ExportResult, SpanData, SpanExporter},
     propagation::{BaggagePropagator, TraceContextPropagator},
-    trace::{Config, Sampler, Tracer, TracerProvider},
+    trace::{Sampler, Tracer, TracerProvider},
 };
 use std::collections::{HashMap, HashSet};
 use std::sync::{Arc, Mutex};
@@ -107,9 +107,7 @@ fn sampling_decision_respects_new_parent() {
     let exporter = TestExporter::default();
     let provider = TracerProvider::builder()
         .with_simple_exporter(exporter.clone())
-        .with_config(
-            Config::default().with_sampler(Sampler::ParentBased(Box::new(Sampler::AlwaysOff))),
-        )
+        .with_sampler(Sampler::ParentBased(Box::new(Sampler::AlwaysOff)))
         .build();
     let tracer = provider.tracer("test");
     let subscriber = tracing_subscriber::registry().with(layer().with_tracer(tracer.clone()));