fix minor typos, build warnings, and clippy warnings on tests #6318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no special clippy flags, just: `cargo clippy --all-features --all-targets`
|
This fails our clippy CI check, most likely because we are using a different version of clippy. You are welcome to upgrade the version of clippy listed in CI. That's in the |
|
1.77-nightly is rather bleeding edge as of now, I don't think its available yet on CI. I'd say this can wait until then? |
|
Ah, yes, we're not going beyond latest stable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no "special" clippy flags, just:
cargo clippy --all-features --all-targets.