Add two build flavors (opensource/full) #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch reworks the build system to build 2 variants of all libs: - An open source only version (only libs that have known source code) - A full version (with amazon device messaging / gcm / play services) This required GCM/ADM files to be moves to a full subfolder and Crashlytics code to be generalized via CrashReporter. There are also 5 more instances of Class.forName / getMethod / ... (cases where generalizing would cause more overhead).
|
I'm adding the rebrand to open-klyph, too. Nearly done. BUT the app requires a fb_app_id and fb_app_secret (will request them on fb, verify your account and I'll add you) |
|
Everything is compiling. The FB mein app failes due to permissions. The FB Messenger is currently untested. I have some other plans for the evening. But you should give the branch a try! |
timoreimann
added a commit
that referenced
this pull request
Jul 6, 2014
Rebrand to OpenKlyph and add two build flavors (opensource/full).
|
Awesome work. Thanks Rene! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch reworks the build system to build 2 variants of all libs:
This required GCM/ADM files to be moves to a full subfolder and
Crashlytics code to be generalized via CrashReporter. There are also 5
more instances of Class.forName / getMethod / ... (cases where
generalizing would cause more overhead).
building is now done via one of
gradle assembleOpensourceDebug
gradle assembleOpensourceRelease
gradle assembleFullDebug
gradle assembleFullRelease