Skip to content

Commit

Permalink
controllers: allow replica count to update without revision change
Browse files Browse the repository at this point in the history
We used to restart every pod in a statefulset (hbasemaster and/or
regionserver) when the replica count changed, instead of simply
allowing statefulset to expand. This is especially unnecessary when
there is no configuration change and the only change was replica
count.

In this change we do not use new replica consider as part of the
revision SHA calculation, but rather reuse the existing replica
count.

Test suite had to be updated to not use any assertions but rather
rely on Eventually() for state verification. This is because
assertions failed randomly, and that was based on timing - if
assertion happened to run when reconciler had not finished updating,
that assertion test would fail. This change removes the dependencies on
timing based issues.
  • Loading branch information
pidren authored and timoha committed May 5, 2021
1 parent 902358f commit fcd95e2
Show file tree
Hide file tree
Showing 3 changed files with 6,489 additions and 1,655 deletions.
Loading

0 comments on commit fcd95e2

Please sign in to comment.