Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: replace tier4_planning_msgs/VelocityLimit to autoware_internal_planning_msgs/VelocityLimit #136

Merged
merged 5 commits into from
Mar 18, 2025

Conversation

mitsudome-r
Copy link
Collaborator

@mitsudome-r mitsudome-r commented Mar 14, 2025

PR Type

  • Improvement

Related Links

Description

This replaces tier4_planning_msgs with autoware_internal_planning_msgs for VelocityLimit as part of porting packages to Autoware Core.

This must be merged with autowarefoundation/autoware_universe#10273.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s).
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Sorry, something went wrong.

Copy link
Collaborator

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, so it's OK if the build passes.

mitsudome-r and others added 3 commits March 18, 2025 16:45

Unverified

The signing certificate or its chain could not be verified.
…_planning_msgs/VelocityLimit

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

Unverified

The signing certificate or its chain could not be verified.
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
@mitsudome-r mitsudome-r force-pushed the replace-velocity-limit branch from 21d529c to 94b4c51 Compare March 18, 2025 07:45
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
@mitsudome-r mitsudome-r force-pushed the replace-velocity-limit branch from aa3a86e to 6216094 Compare March 18, 2025 08:46
@mitsudome-r mitsudome-r merged commit c771ce5 into tier4:tier4/universe Mar 18, 2025
8 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (ab4dd4d) to head (6216094).
Report is 3 commits behind head on tier4/universe.

Files with missing lines Patch % Lines
autoware_iv_internal_api_adaptor/src/velocity.cpp 0.00% 6 Missing ⚠️
awapi_awiv_adapter/src/awapi_awiv_adapter_core.cpp 0.00% 2 Missing ⚠️
..._awiv_adapter/src/awapi_max_velocity_publisher.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           tier4/universe    #136     +/-   ##
================================================
  Coverage            0.00%   0.00%             
================================================
  Files                  60      39     -21     
  Lines                2667    1514   -1153     
  Branches                0     139    +139     
================================================
+ Misses               2667    1514   -1153     
Flag Coverage Δ
differential 0.00% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants