Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace debug_msgs in localization_score #132

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

SakodaShintaro
Copy link
Contributor

@SakodaShintaro SakodaShintaro commented Feb 3, 2025

PR Type

  • Bug Fix

Related Links

Description

In autoware, the messages used for debugging have been changed from tier4_debug_msgs to autoware_internal_debug_msgs.

This pull request replaces the type of debug_msgs used in localization_score with the above changes.

Before

[ERROR] [1738547974.209400077] [ROSBAG2_TRANSPORT]: Topic '/localization/pose_estimator/nearest_voxel_transformation_likelihood' has more than one type associated. Only topics with one type are supported
$ ros2 topic info -v /localization/pose_estimator/nearest_voxel_transformation_likelihood
Type: ['autoware_internal_debug_msgs/msg/Float32Stamped', 'tier4_debug_msgs/msg/Float32Stamped']
Publisher count: 1
Node name: ndt_scan_matcher
Node namespace: /localization/pose_estimator
Topic type: autoware_internal_debug_msgs/msg/Float32Stamped
Endpoint type: PUBLISHER
GID: 01.10.b9.e1.9a.9d.58.66.fe.68.ca.4f.00.00.27.03.00.00.00.00.00.00.00.00
QoS profile:
  Reliability: RELIABLE
  History (Depth): KEEP_LAST (10)
  Durability: VOLATILE
  Lifespan: Infinite
  Deadline: Infinite
  Liveliness: AUTOMATIC
  Liveliness lease duration: Infinite

Subscription count: 2

Node name: localization_score
Node namespace: /autoware_api/external
Topic type: tier4_debug_msgs/msg/Float32Stamped
Endpoint type: SUBSCRIPTION
GID: 01.10.06.49.8b.01.19.e4.98.05.c9.d3.00.00.c8.04.00.00.00.00.00.00.00.00
QoS profile:
  Reliability: RELIABLE
  History (Depth): KEEP_LAST (1)
  Durability: VOLATILE
  Lifespan: Infinite
  Deadline: Infinite
  Liveliness: AUTOMATIC
  Liveliness lease duration: Infinite

Node name: rosbag2_recorder
Node namespace: /
Topic type: autoware_internal_debug_msgs/msg/Float32Stamped
Endpoint type: SUBSCRIPTION
GID: 01.10.26.81.ed.53.74.03.01.df.9a.98.00.00.3e.04.00.00.00.00.00.00.00.00
QoS profile:
  Reliability: RELIABLE
  History (Depth): KEEP_LAST (10)
  Durability: VOLATILE
  Lifespan: Infinite
  Deadline: Infinite
  Liveliness: AUTOMATIC
  Liveliness lease duration: Infinite

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s).
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Sorry, something went wrong.

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
@SakodaShintaro SakodaShintaro self-assigned this Feb 3, 2025
@SakodaShintaro SakodaShintaro marked this pull request as ready for review February 3, 2025 02:36
@rej55 rej55 merged commit 4dbe2ed into tier4/universe Feb 3, 2025
11 checks passed
@rej55 rej55 deleted the fix/replace_debug_msgs branch February 3, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants