Feat/v0.19.2/multi tracker sanitize update #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
まずは変更点の可視化から。 |
YoshiRi
approved these changes
Mar 12, 2025
TadaKazuto
force-pushed
the
feat/v0.19.2/multi-tracker-sanitize-update
branch
from
a0e57c1 to
3aabafd
Compare
|
This was referenced Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update sanitization(prune) process to fix the issue of temp lost for a laying adult found in LSim perception test
追加したソートの考え方：
Known objects(NO-UNKNOWN objs)かどうかを第一条件、meas timeを第二条件としてソートすることで、tracking objの削除が発生する場合は、”必ずインデックスの小さい方が大きい方を消す”ようにして、forループ以後の処理を単純化
(
Added sorting concept:
By sorting with known objects (NO-UNKNOWN objs) as the first condition and mean time as the second condition, when a tracking obj is deleted, the smaller index will always delete the larger one, so that simplifying the processing after the for loop.
)
Related links
TBD
Parent Issue:
How was this PR tested?
Minimum test on evaluator to check there is no side effect
https://evaluation.tier4.jp/evaluation/reports/04ac5b9d-1229-5171-8360-f8d67ce2d7fa?project_id=x2_dev
ベンチマークでは98.1->98.6と0.5ptの改善(最後のcommitを取り入れると98.7まで改善)
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.