Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflow): modify workflow from sync-awf-latest workflow #1167

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

takayuki5168
Copy link

@takayuki5168 takayuki5168 commented Mar 1, 2024

Description

The sync-awf-latest workflow may modify the .github/workflows directory since it force-pushes the commits of awf/autoware.universe directly.
Since the workflow cannot modify the directory by default, the workflow sometimes fails as follows.
https://github.com/tier4/autoware.universe/actions/runs/8096410145/job/22125118729

To fix this issue, this PR added a token in the workflow file to permit the modification. This token was generated by the TIER IV's github admin and registered to the secret variable in tier4/autoware.universe by @tkimura4

Tests performed

just run a sync-awf-latest without further testing
https://github.com/tier4/autoware.universe/actions/runs/8115389770

Effects on system behavior

sync-awf-latest will not fail when it modifies the workflow directory.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review March 1, 2024 18:08
Copy link
Collaborator

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 1bebdab into tier4/main Mar 2, 2024
25 checks passed
@tkimura4 tkimura4 deleted the feat/modify-workflow-from-workflow branch March 2, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants