feat(behavior_path _planner): divide planner manager modules into dependent slots (#8117, #7881, #7764) #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utowarefoundation#7764) * feat(behavior_path_planner): remove max_module_size param The max_module_size param has been removed from the behavior_path_planner scene_module_manager.param.yaml file. This param was unnecessary and has been removed to simplify the configuration. Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…ing scene module process (autowarefoundation#7881) * prevent infinite loop Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * calculate max_iteration_num from number of scene modules Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add doxygen explanation for calculateMaxIterationNum Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…endent slots (autowarefoundation#8117) Signed-off-by: k-hazama-esol <k-hazama@esol.co.jp>
k-hazama-esol
force-pushed
the
cherry-pick/trajectory_intermittent_merge_PR/beta_x2_gen2_v0.29.2
branch
from
18af129 to
52e21e4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
※元々は#1882 でPRを作成していたが、修正箇所を過去の変更の取り込みで対応する方針となったため、新たにPRを作成する運びとなった。作成経緯の詳細は#1882 のコメント参照
Related links
Parent Issue:
cherry-pick PR:
Related PR:
How was this PR tested?
コメントのPRを取り込んだunverseを用いたpilot.auto.x2環境(77340e4)と元のPR内容のuniverseを用いたpilot.auto.x2環境(badf675)、および直近でEvaluatorにかけられた同バージョンのpilot.auto.x2環境(beta/4.0.2)との比較を以下の表に示す。
Evaluatorの比較結果ページへのリンクはこちら。
上記結果より、大幅なOK/NGの増減が無いためデグレーションなく取り込めていると判断する。
Notes for reviewers
GitHubでのCI/CD実施時に以下エラーが発生
cppcheck-differential
DCO
pre-commit-optional
spell-check-differential
上記issue/エラーについて、今回のPRで指摘を修正するとなると、cherry-pickの範囲を越えることになるため、修正しないという方針で進めさせていただきたい。
Interface changes
None.
Effects on system behavior
None.