Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compare_map_segmentation): tuning compare map filter for lv4 test #1170

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

YoshiRi
Copy link

@YoshiRi YoshiRi commented Mar 4, 2024

Description

EN:

This PR contains cherry pick autowarefoundation#6429
and temporary changes for level 4 low object detection test.

As discussed in autowarefoundation#6439, we can loose compare map based ground filtering by slightly shifting voxel collision point.

The latter should be removed for normal process.

JP:

Lv4認可試験向けの調整です。

AWFの下記のBugfixを取り込みつつ、さらにVoxelGridの判定をやや下側にずらし、計算量を増やさないまま地面点群の除去判定を甘くすることができます。

autowarefoundation#6429

magic numberの0.1が入っているのがそれに該当します。

関連PR:autowarefoundation#6439
でも議論したようにこの0.1は邪道なので然るべき後に消すべきです。

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@YoshiRi YoshiRi changed the title feat((compare_map_segmentation): tuning compare map filter for lv4 test feat(compare_map_segmentation): tuning compare map filter for lv4 test Mar 4, 2024
@YoshiRi YoshiRi requested a review from 0x126 March 4, 2024 18:07
@YoshiRi YoshiRi marked this pull request as draft March 4, 2024 18:09
YoshiRi and others added 2 commits March 12, 2024 00:08
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@0x126 0x126 force-pushed the experiment/lv4_test_v0.19.1_base branch from eac2daa to 9ce48d0 Compare March 11, 2024 15:08
@0x126 0x126 marked this pull request as ready for review March 11, 2024 15:08
@0x126 0x126 merged commit 9133ea1 into beta/v0.19.1 Mar 11, 2024
13 checks passed
@0x126 0x126 deleted the experiment/lv4_test_v0.19.1_base branch March 11, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants