feat(compare_map_segmentation): tuning compare map filter for lv4 test #1170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EN:
This PR contains cherry pick autowarefoundation#6429
and temporary changes for level 4 low object detection test.
As discussed in autowarefoundation#6439, we can loose compare map based ground filtering by slightly shifting voxel collision point.
The latter should be removed for normal process.
JP:
Lv4認可試験向けの調整です。
AWFの下記のBugfixを取り込みつつ、さらにVoxelGridの判定をやや下側にずらし、計算量を増やさないまま地面点群の除去判定を甘くすることができます。
autowarefoundation#6429
magic numberの0.1が入っているのがそれに該当します。
関連PR:autowarefoundation#6439
でも議論したようにこの0.1は邪道なので然るべき後に消すべきです。
Related links
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.