Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: to work with nebula's main branch #377

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

SakodaShintaro
Copy link
Contributor

@SakodaShintaro SakodaShintaro commented Jan 28, 2025

This pull request introduces a required change to run logging_simulator with pilot-auto.vanilla and the main branch of nebula (tier4/nebula@33e77cf).

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
@SakodaShintaro SakodaShintaro self-assigned this Jan 28, 2025
@mojomex
Copy link
Contributor

mojomex commented Feb 5, 2025

In v0.2.3 which is the target for the next Pilot.Auto release, the ptp_lock_threshold parameter was added (see Hesai parameter docs).
Could you add support for that parameter in this PR, too?

SakodaShintaro and others added 2 commits February 6, 2025 08:57
@SakodaShintaro
Copy link
Contributor Author

@mojomex
Thank you for your comment.
I have added the parameter. f867842.

Note:
We (Release Engineering Team) only have tests for xx1's sensor_kit. We cannot test for X2, hesai.

And X2 uses its own nebula_node_container.launch.py not the one in common_sensor_launch. (https://github.com/tier4/aip_launcher/blob/tier4/universe/aip_x2_gen2_launch/launch/nebula_node_container.launch.py)
The X2's nebula_node_container.launch.py will be fixed by hihara-san in another PR.

@SakodaShintaro SakodaShintaro merged commit 5bc60cf into tier4/universe Feb 7, 2025
10 of 11 checks passed
@SakodaShintaro SakodaShintaro deleted the fix/with_nebula_main_20250128 branch February 7, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants