Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove setup-jest files #2995

Merged
merged 1 commit into from
Feb 28, 2025
Merged

refactor: remove setup-jest files #2995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions scripts/test-examples.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,11 @@ const executeTest = (projectPath) => {
logger.log('installing bundled version of jest-preset-angular');
logger.log();

['build', 'presets', 'jest-preset.js', 'package.json', 'setup-jest.js', 'setup-jest.mjs', 'setup-env'].forEach(
(asset) => {
const assetToReplace = join(projectPath, 'node_modules', 'jest-preset-angular', asset);
const assetToCopy = join(rootDir, asset);
copySync(assetToCopy, assetToReplace, {});
},
);
['build', 'presets', 'jest-preset.js', 'package.json', 'setup-env'].forEach((asset) => {
const assetToReplace = join(projectPath, 'node_modules', 'jest-preset-angular', asset);
const assetToCopy = join(rootDir, asset);
copySync(assetToCopy, assetToReplace, {});
});

// then we can run the tests
const cmdLine = ['yarn', 'test'];
Expand Down
32 changes: 0 additions & 32 deletions setup-jest.js
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions setup-jest.mjs
View file
Open in desktop

This file was deleted.

47 changes: 3 additions & 44 deletions src/config/setup-jest.spec.ts → src/config/setup-env.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jest.mock('@angular/core', () => {
};
});

describe('setup-jest', () => {
describe('Setup env utilities', () => {
const assertOnInitTestEnv = (): void => {
expect(mockGetTestBed).toHaveBeenCalled();
expect(mockInitTestEnvironment.mock.calls[0][0][0]).toBeInstanceOf(BrowserDynamicTestingModuleStub);
Expand All @@ -64,33 +64,12 @@ describe('setup-jest', () => {
};

beforeEach(() => {
delete globalThis.ngJest;
delete globalThis.TextEncoder;
jest.clearAllMocks();
jest.resetModules();
});

describe('for CJS setup-jest, test environment initialization', () => {
it('should setup test environment with setup-jest file', async () => {
globalThis.ngJest = {
testEnvironmentOptions: {
teardown: {
destroyAfterEach: false,
rethrowErrors: true,
},
errorOnUnknownElements: true,
errorOnUnknownProperties: true,
},
};

await import('../../setup-jest.js');

expect(globalThis.TextEncoder).toBeDefined();
expect(mockZoneJs).toHaveBeenCalled();
expect(mockZoneJsTesting).toHaveBeenCalled();
assertOnInitTestEnv();
});

describe('for CJS, test environment initialization', () => {
it('should setup test environment with setupZoneTestEnv()', async () => {
const { setupZoneTestEnv } = await import('../../setup-env/zone/index.js');

Expand Down Expand Up @@ -129,27 +108,7 @@ describe('setup-jest', () => {
});
});

describe('for ESM setup-jest, test environment initialization', () => {
it('should setup test environment with setup-jest file', async () => {
globalThis.ngJest = {
testEnvironmentOptions: {
teardown: {
destroyAfterEach: false,
rethrowErrors: true,
},
errorOnUnknownElements: true,
errorOnUnknownProperties: true,
},
};

await import('../../setup-jest.mjs');

expect(globalThis.TextEncoder).toBeDefined();
expect(mockZoneJs).toHaveBeenCalled();
expect(mockZoneJsTesting).toHaveBeenCalled();
assertOnInitTestEnv();
});

describe('for ESM, test environment initialization', () => {
it('should setup test environment with setupZoneTestEnv()', async () => {
const { setupZoneTestEnv } = await import('../../setup-env/zone/index.mjs');

Expand Down