refactor: remove global setup script with ngcc
#2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR refactors the project by removing the global setup script and all associated files that were used to run ngcc for Jest. The key changes include:
- Removal of the global setup test specification (global-setup.spec.ts)
- Removal of the global setup entry points in various module formats (global-setup.mjs and global-setup.js)
- Removal of the ngcc processing functionality (ngcc-jest-processor.ts and global-setup.ts)
Reviewed Changes
| File | Description |
|---|---|
| src/config/global-setup.spec.ts | Removed tests for the global setup script |
| global-setup.mjs | Removed module-based global setup entry point |
| global-setup.js | Removed CommonJS global setup entry point |
| src/utils/ngcc-jest-processor.ts | Removed the ngcc processing logic for Jest |
| src/config/global-setup.ts | Removed the global setup function that invoked ngcc |
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
BREAKING CHANGE Running 'ngcc' is not required for Angular 16+ projects
ahnpnl
force-pushed
the
refactor/remove-ngcc
branch
from
7a56c96 to
f8d4c99
Compare
There was a problem hiding this comment.
PR Overview
This PR removes the global setup script that uses ngcc from the project.
- Removed references to global setup files from asset copying in test-examples.js.
- Removed deprecated Angular Ivy documentation and ngcc processor-related files.
- Deleted global setup configuration and associated tests.
Reviewed Changes
| File | Description |
|---|---|
| scripts/test-examples.js | Removed references to global setup scripts from asset list. |
| website/docs/guides/angular-ivy.md | Deleted outdated Angular Ivy guide. |
| src/utils/ngcc-jest-processor.ts | Removed ngcc processor implementation. |
| src/config/global-setup.ts | Removed global setup configuration. |
| src/config/global-setup.spec.ts | Removed tests for the removed global setup. |
| global-setup.mjs | Deleted legacy global setup module. |
| global-setup.js | Deleted legacy global setup module. |
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
scripts/test-examples.js:42
- The extra comma after the arrow function block may cause a syntax error. Removing it should fix any potential parsing issues.
},
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
Green CI
Does this PR introduce a breaking change?
Other information
N.A.