Drop support for Node version lower than 18 #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This pull request drops support for Node versions lower than 18 by updating configuration files and improving snapshot stability. Key changes include:
- Replacing the JavaScript commitlint configuration with a TypeScript version.
- Updating the Angular snapshot serializer to remove dynamically generated "id" attributes.
- Removing the deprecated commitlint.config.js file.
Reviewed Changes
| File | Description |
|---|---|
| commitlint.config.ts | New TypeScript-based commitlint configuration with updated rules. |
| src/serializers/no-ng-attributes.ts | Enhanced serializer to remove unstable "id" attributes from nodes. |
| commitlint.config.js | Removal of outdated commitlint configuration file. |
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
BREAKING CHANGE The support versions are `^18.19.1 || ^20.11.1 || >=22.0.0`
ahnpnl
force-pushed
the
refactor/drop-node-smaller-18
branch
from
fb16365 to
2903991
Compare
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
Green CI
Does this PR introduce a breaking change?
Other information
N.A.