Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make logging conditional #2

Closed
wants to merge 1 commit into from
Closed

Conversation

itamm15
Copy link

@itamm15 itamm15 commented Jan 9, 2025

Terminal:

[error] 14:49:17.137 application=broadway_sqs file=lib/broadway_sqs/aws_elixir_client.ex line=96 mfa=BroadwaySQS.AwsElixirClient.wrap_received_messages/2 
Unable to fetch events from AWS queue test. Reason: "The security token included in the request is expired"

Let's have a way to disable loggs from the Portal app level (via dev config)

@itamm15 itamm15 self-assigned this Jan 9, 2025
@jhosteny
Copy link
Contributor

jhosteny commented Jan 9, 2025

Hi @itamm15, one quick question here. In ex_ark, I added a [domain: :ex_ark] to that library's logger, so that I could suppress messages to sentry using exclude_domains. Is there anything like that in the Phoenix logger config that we could use? I don't think so? The closest thing seems to be a filter, but I don't immediately see that the log_event has the domain (but I only looked briefly).

@itamm15
Copy link
Author

itamm15 commented Jan 13, 2025

@jhosteny closing in lieu of https://github.com/thoroai/portal/pull/911

@itamm15 itamm15 closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants