Skip to content

Commit

Permalink
fix: Add new line after last line in credentials file
Browse files Browse the repository at this point in the history
Closes #13
  • Loading branch information
theurichde committed Apr 29, 2022
1 parent c3d193c commit 2ec6d1f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions cmd/go-aws-sso/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ func Test_processCredentialsTemplate(t *testing.T) {
SessionToken: &sessionToken,
}},
},
want: "[default]\naws_access_key_id = access_key_id\naws_secret_access_key = secret_access_key\naws_session_token = session_token\noutput = json\nregion = eu-central-1",
want: "[default]\naws_access_key_id = access_key_id\naws_secret_access_key = secret_access_key\naws_session_token = session_token\noutput = json\nregion = eu-central-1\n",
},
}

Expand Down Expand Up @@ -259,7 +259,7 @@ func Test_start(t *testing.T) {
homeDir, _ := os.UserHomeDir()
content, _ := ioutil.ReadFile(homeDir + "/.aws/credentials")
got := string(content)
want := "[default]\naws_access_key_id = dummy\naws_secret_access_key = dummy\naws_session_token = dummy\noutput = json\nregion = eu-central-1"
want := "[default]\naws_access_key_id = dummy\naws_secret_access_key = dummy\naws_session_token = dummy\noutput = json\nregion = eu-central-1\n"

if got != want {
t.Errorf("Got: %v, but wanted: %v", got, want)
Expand Down
2 changes: 1 addition & 1 deletion internal/assume_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ func TestAssumeDirectly(t *testing.T) {
// TODO: Use a temporary credentials file for testing!
content, _ := ioutil.ReadFile(homeDir + "/.aws/credentials")
got := string(content)
want := "[default]\naws_access_key_id = dummy_assume_directly\naws_secret_access_key = dummy_assume_directly\naws_session_token = dummy_assume_directly\noutput = json\nregion = eu-central-1"
want := "[default]\naws_access_key_id = dummy_assume_directly\naws_secret_access_key = dummy_assume_directly\naws_session_token = dummy_assume_directly\noutput = json\nregion = eu-central-1\n"

if got != want {
t.Errorf("Got: %v, but wanted: %v", got, want)
Expand Down
3 changes: 2 additions & 1 deletion internal/file_system.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ aws_access_key_id = {{access_key_id}}
aws_secret_access_key = {{secret_access_key}}
aws_session_token = {{session_token}}
output = json
region = eu-central-1`
region = eu-central-1
`

engine := fasttemplate.New(template, "{{", "}}")
filledTemplate := engine.ExecuteString(map[string]interface{}{
Expand Down

0 comments on commit 2ec6d1f

Please sign in to comment.