Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/pre commit cleanup #41

Merged
merged 12 commits into from
Feb 17, 2025
Merged

Chore/pre commit cleanup #41

merged 12 commits into from
Feb 17, 2025

Conversation

zimea
Copy link
Contributor

@zimea zimea commented Feb 17, 2025

Formatting scripts and code that didn't adhere to the code format configs

@zimea zimea self-assigned this Feb 17, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@zimea zimea requested review from timtreis and Zethson and removed request for timtreis February 17, 2025 15:22
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it fine with you if the uid is always removed for all of the scripts in data?

@zimea
Copy link
Contributor Author

zimea commented Feb 17, 2025

The files in /data/ are mostly the original files by Tim and I simply didn't want to discard them until we have a working example. If it bothers you, we can remove it, but they will be updated or cleaned up sooner or later

@zimea
Copy link
Contributor Author

zimea commented Feb 17, 2025

I'll merge this for now, so I can continue with a cleaned repo. Let me know if we should re-open it

@zimea zimea merged commit 9848d7b into main Feb 17, 2025
5 checks passed
@zimea zimea deleted the chore/pre-commit-cleanup branch February 18, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants