Fixes #36207 - assign puppet attributes from hostgroup #401
Conversation
| save | ||
| end | ||
|
|
||
| def inherited_attributes |
There was a problem hiding this comment.
This method is missing for sure so that attributes from hostgroup are used. Same as in katello, openscap, salt...
There was a problem hiding this comment.
Do you know @ekohl (or know someone who maybe can answer this question), why this method did not exist in puppet but is used for Katello, OpenSCAP, Salt.
How does this work, if you create a host which is using a hostgroup, that this host is using the "templated values" from hostgroup without this code?
There was a problem hiding this comment.
As this is related to facets (environment_id is provided by the puppet facet), maybe we can also ping @ShimShtein
| @@ -55,6 +55,15 @@ def search_by_config_group(_key, operator, value) | |||
| end | |||
|
|
|||
| module PrependedMethods | |||
| def environment_id=(id) | |||
| self.environment = ForemanPuppet::Environment.find(id) | |||
| save | |||
There was a problem hiding this comment.
Is this good or does it break something to have a environment_id method?
can the save be improved?
| @@ -30,6 +30,26 @@ class << self | |||
| ext_method: :search_by_config_group | |||
| end | |||
|
|
|||
| def inherited_puppet_hostgroup_attribute(attribute) | |||
| if ancestry.present? | |||
There was a problem hiding this comment.
grabbed and adapted from foreman_openscap
No description provided.