Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(metadata): add vpc_service_control_attach_dry_run #905

Merged
merged 3 commits into from
May 2, 2024
Merged

chore(metadata): add vpc_service_control_attach_dry_run #905

merged 3 commits into from
May 2, 2024

Conversation

eeaton
Copy link
Contributor

@eeaton eeaton commented May 2, 2024

PR to address #904

vpc_service_control_attach_dry_run was not previously included in metadata file so it was not exposed to the module

@eeaton eeaton requested a review from a team as a code owner May 2, 2024 15:52
@daniel-cit
Copy link
Contributor

@apeabody Cloud you trigger a new release ?
#895

cc: @eeaton

@apeabody
Copy link
Contributor

apeabody commented May 2, 2024

@apeabody Cloud you trigger a new release ? #895

cc: @eeaton

Yeah, let me try and merge a few of these PRs and get a clean build.

@apeabody apeabody self-assigned this May 2, 2024
@apeabody apeabody changed the title fix(metadata): add vpc_service_control_attach_dry_run chore(metadata): add vpc_service_control_attach_dry_run May 2, 2024
@apeabody apeabody enabled auto-merge (squash) May 2, 2024 19:40
@apeabody apeabody merged commit 93359e1 into terraform-google-modules:master May 2, 2024
4 checks passed
@eeaton eeaton mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

Assignees

@apeabody apeabody

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eeaton @daniel-cit @apeabody