Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add variable create_route to control creation of route #98

Conversation

IlyesDemineExtVeolia
Copy link
Contributor

@IlyesDemineExtVeolia IlyesDemineExtVeolia commented Feb 12, 2024

Description

Fixes #97

Motivation and Context

Can be useful to have a variable to control creation of route

Breaking Changes

No breaking changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@IlyesDemineExtVeolia IlyesDemineExtVeolia changed the title feat: add variable create_route to control creation of route feat: Add variable create_route to control creation of route Feb 12, 2024
@IlyesDemineExtVeolia
Copy link
Contributor Author

Hello Need review please 🙂 @antonbabenko

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there is just a minor improvement.

@IlyesDemineExtVeolia
Copy link
Contributor Author

Thanks for your review

@antonbabenko antonbabenko merged commit 68ad2b1 into terraform-aws-modules:master Feb 12, 2024
7 checks passed
antonbabenko pushed a commit that referenced this pull request Feb 12, 2024
## [3.1.0](v3.0.0...v3.1.0) (2024-02-12)

### Features

* Add variable create_route to control creation of route ([#98](#98)) ([68ad2b1](68ad2b1))
@antonbabenko
Copy link
Member

This PR is included in version 3.1.0 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: create a variable bool for create route
2 participants