feature: clear_vibrancy, NSVisualEffectViewTagged #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w; implement a NSVisualEffectView subview with tag for matching the blurred view in the window; add IntelliJ IDEA and macOS-specific files to gitignore
petersamokhin
force-pushed
the
feature-macos-vibrancy-clear
branch
from
a3471d8 to
7174bf4
Compare
petersamokhin
commented
Feb 7, 2025
There was a problem hiding this comment.
Just moved from macos.rs to macos/mod.rs + macos/internal.rs + macos/ns_visual_effect_view_tagged.rs.
Public API contract of this crate is not affected
|
btw @amrbashir is this separate repo deprecated or not? we can merge this PR and I can prepare another one for tauri, if it makes sense |
|
It is not deprecated, tauri uses it under the hood. The file you linked, just does some conversions from tauri types to this crate types. |
amrbashir
approved these changes
Feb 12, 2025
amrbashir
requested changes
Feb 12, 2025
|
@amrbashir thanks, added 🫡 Btw, I added this as a |
amrbashir
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once merged, this PR will:
NSVisualEffectViewwith a custom tag, to find the view in the windowclear_vibrancy(similar to the existingclear_blur,clear_mica, etc.) by finding the custom blurred view and removing it from the windowTested on macOS 15.3 ✅