Make gtk an optional feature #283
Open
+24
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Note that this is actually a breaking change for it will break the Linux build if one did |
amrbashir
requested changes
Mar 7, 2025
Cargo.toml
Outdated
| default = ["libxdo"] | ||
| libxdo = ["dep:libxdo"] | ||
| default = ["libxdo", "gtk"] | ||
| libxdo = ["dep:libxdo", "gtk"] |
There was a problem hiding this comment.
i think this can stay as is
Suggested change
| libxdo = ["dep:libxdo", "gtk"] | |
| libxdo = ["dep:libxdo"] |
This helps projects that uses muda on platform other than Linux to not get the gtk dependencies in their Cargo.lock (and the security advisories that goes with it) Fixes tauri-apps#282
amrbashir
reviewed
Mar 8, 2025
This should be a minor since breaking changes are allowed in minor releases for 0.x versions Co-authored-by: Amr Bashir <github@amrbashir.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps projects that uses muda on platform other than Linux to not get the gtk dependencies in their Cargo.lock (and the security advisories that goes with it)
Fixes #282