Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the summed CSVs and model's cost and human-readable name, since they will be handled afterwards with tooling #256

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Remove the summed CSVs and model's cost and human-readable name, since they will be handled afterwards with tooling #256

merged 2 commits into from
Jul 12, 2024

Conversation

ruiAzevedo19
Copy link
Contributor

Part of #205

@ruiAzevedo19 ruiAzevedo19 added the enhancement New feature or request label Jul 10, 2024
@ruiAzevedo19 ruiAzevedo19 added this to the v0.6.0 milestone Jul 10, 2024
@ruiAzevedo19 ruiAzevedo19 self-assigned this Jul 10, 2024
@ruiAzevedo19 ruiAzevedo19 changed the title Remove the summed CSV reports, markdown reports, and the model's cost and human-readable name information, since they will be handled afterwards with tooling Remove the summed CSV and markdown reports, and the model's cost and human-readable name information, since they will be handled afterwards with tooling Jul 10, 2024
@ruiAzevedo19 ruiAzevedo19 requested a review from bauersimon July 10, 2024 13:50
@ruiAzevedo19 ruiAzevedo19 changed the title Remove the summed CSV and markdown reports, and the model's cost and human-readable name information, since they will be handled afterwards with tooling Remove the summed CSV and markdown reports, since they will be handled afterwards with tooling Jul 10, 2024
bauersimon
bauersimon requested changes Jul 11, 2024
View reviewed changes
@ruiAzevedo19 ruiAzevedo19 requested a review from bauersimon July 11, 2024 08:49
@ruiAzevedo19 ruiAzevedo19 changed the title Remove the summed CSV and markdown reports, since they will be handled afterwards with tooling Remove the summed CSVs and model's cost and human-readable name, since they will be handled afterwards with tooling Jul 11, 2024
This was referenced Jul 11, 2024
Merged
Closed
@ruiAzevedo19
Remove all occurrences of model costs and human-readable names, since…
aa44c7a 
… they will be handled afterwards with tooling

Part of #237
@ruiAzevedo19
Remove the logic to write the "models-summed.csv" and "<language>-sum…
72ab41c 
…med.csv" files, since they will be handled afterwards with tooling

Part of #237
@bauersimon bauersimon merged commit b0be5f7 into main Jul 12, 2024
5 checks passed
@bauersimon bauersimon deleted the 205-remove-csvs branch July 12, 2024 08:30
@bauersimon bauersimon mentioned this pull request Jul 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bauersimon bauersimon bauersimon approved these changes

Assignees

@ruiAzevedo19 ruiAzevedo19

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ruiAzevedo19 @bauersimon