Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rework Stripe Google Pay using the payment request button #154

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

vstudenichnik-insoft
Copy link
Contributor

https://app.asana.com/0/1203838771973396/1205867429173200/f

Description

The current integration works directly with the Google Pay API. However, for some reason, the Google Pay API sometimes returns an error when clicking the pay button.

Therefore, it was decided to rework the Stripe Google Pay integration using the Stripe Payment Request Button. This provides the following benefits:

  • Ability to select a shipping method in the Google Pay modal;
  • 3DS support, including for recurring payments.

Copy link
Contributor

@swellmike swellmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

➕ for DRYing up the payment request data

@vstudenichnik-insoft vstudenichnik-insoft merged commit 7d81df1 into master Feb 1, 2024
1 check passed
@vstudenichnik-insoft vstudenichnik-insoft deleted the fix/stripe-google-pay branch February 1, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants