feat: implement auto webhook creation #13
Conversation
|
I think you might be the first external contributor here @thesayyn, thanks ! I'll try review this in the next couple of days, but from first skim this looks amazing |
src/utils/config.ts
Outdated
| @@ -6,10 +6,14 @@ type configType = { | |||
| SCHEMA: string | |||
| STRIPE_SECRET_KEY: string | |||
| STRIPE_WEBHOOK_SECRET: string | |||
There was a problem hiding this comment.
Looks like this has been removed from .env.sample
There was a problem hiding this comment.
Tests were failing with or without it so I wasn’t sure whether this should be removed.
I could remove it if I could get the tests to pass.
There was a problem hiding this comment.
Also:
Users could leave empty the STRIPE_WEBHOOK_URL property and fill this one to opt-out from the automatic creation of the hook.
There was a problem hiding this comment.
Maybe i should clarify this in the documentation
There was a problem hiding this comment.
The tests pass on my local, but the need a bit of set up:
- create a database on Supabase
- grab the Database URL from the settings
- fill out the
.envfile:
NODE_ENV=production
STRIPE_SECRET_KEY=sk_test_XXXX
STRIPE_WEBHOOK_SECRET=whsec_XXXX
SCHEMA=stripe
DATABASE_URL=postgres://postgres:XXXX@db.XXX.supabase.co:5432/postgres?sslmode=disable&search_path=stripe
- Run
dbmate up(will create the stripe tables) - Run
npm run test
I guess I should add a local postgres with docker to make this process a bit simpler
There was a problem hiding this comment.
Yes that would make more sense
There was a problem hiding this comment.
OK so now that I read through the PR, is there a way that we can mock Stripe so we don't need an account? Previously I was just testing again local copies of Stripe events, and now it looks like it will need a valid STRIPE_SECRET (correct me if I'm wrong)
There was a problem hiding this comment.
yes, we can mock stripe if we do not use it directly. we could create helper functions that do the thing we want and we can have a mock version of them instead of a mocked stripe library which is way too complex.
There was a problem hiding this comment.
There are ways we could avoid auto-creation of webhook by not supplying the webhook URL. hence the creation will be skipped.
That’s awesome. I just wanted to have fun with this. 🤓 |
|
Any updates on this? |
|
That would be amazing! Any updates on that? @thesayyn @kiwicopple Is it just blocked by review? |
|
@kevcodez - perhaps you can jump on this one when you get a chance |
What kind of change does this PR introduce?
feature
What is the current behavior?
Before these changes, the webhook was created manually which is error-prone and time-consuming.
#4
What is the new behavior?
Webhooks are automatically created and updated if there is any change on the stripe side.
Additional context
Add any other context or screenshots.