Blog post showing how to process eclipse photos with SunPy #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtbarnes
changed the title
ayshih
reviewed
Apr 5, 2024
Co-authored-by: Albert Y. Shih <ayshih@gmail.com>
Co-authored-by: Albert Y. Shih <ayshih@gmail.com>
Cadair
commented
Apr 5, 2024
nabobalis
reviewed
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
| "outputs": [], | ||
| "source": [ | ||
| "im_rgb = np.flipud(matplotlib.image.imread(SOLAR_ECLIPSE_IMAGE))\n", | ||
| "im = np.average(im_rgb, axis=2)" |
There was a problem hiding this comment.
Do we need to do something like from skimage.color import rgb2gray instead of an average?
Or does it not matter?
nabobalis
reviewed
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
Comment on lines
+187
to
+188
| "blur_im = ndimage.gaussian_filter(im, 8)\n", | ||
| "mask = blur_im > blur_im.mean() * 3\n", |
There was a problem hiding this comment.
Any reason for these "magic" numbers or shall we just gloss over it?
nabobalis
reviewed
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
nabobalis
approved these changes
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
nabobalis
reviewed
Apr 6, 2024
|
Thanks everyone, hopefully the weather lets us see it tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the 2024 eclipse, this blog post shows an example of how to process an eclipse photograph with SunPy using an observation from the 2017 eclipse. This is adapted from here: https://github.com/sunpy/solar-eclipse