Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [14.0][IMP] report_async: direct dialog on Print #3

Open
wants to merge 12 commits into
base: 14.0
Choose a base branch
from

Conversation

thomaspaulb
Copy link
Member

No description provided.

@KKamaa KKamaa force-pushed the 14.0-imp-report_async branch 2 times, most recently from f414222 to b808f8a Compare March 22, 2022 03:31
@KKamaa
Copy link

KKamaa commented Mar 31, 2022

@thomaspaulb added js test for this, to test the popup dialog functionality;

success

there is some weird error about, ImportError: cannot import name '_unicodefun' from 'click', think lint needs a check as per the show here. Seems the only soln is to upgrade the click module as show here

@thomaspaulb thomaspaulb force-pushed the 14.0-imp-report_async branch from cb97b90 to 2fb1f29 Compare April 11, 2022 16:10
@KKamaa
Copy link

KKamaa commented Apr 13, 2022

@thomaspaulb its ok now think a rebase was all that was required as you mentioned. So when @kittiu's MR is merged will push this to OCA as an improvement request.

@KKamaa KKamaa force-pushed the 14.0-imp-report_async branch from 9440de7 to 359b913 Compare April 13, 2022 13:32
@thomaspaulb
Copy link
Member Author

@KKamaa I saw that that one is now merged!

@KKamaa
Copy link

KKamaa commented Apr 13, 2022

@KKamaa I saw that that one is now merged!

Yes I made a new PR for improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants