-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
supplement to feature "Gemini detects language to translate" #45
Open
duong2417
wants to merge
29
commits into
suesitran:main
Choose a base branch
from
duong2417:gemini_detect_language_to_translate_PR
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
supplement to feature "Gemini detects language to translate" #45
duong2417
wants to merge
29
commits into
suesitran:main
from
duong2417:gemini_detect_language_to_translate_PR
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
duong2417
commented
Feb 23, 2025
- add See more
- check if detectedLanguage is the same locale language, not show translation
- fix align text of translation (mine):
…first message that Gemini detect
…est to both detect language and translate message
…ble_widget: fix null check poniter, not translate for mine. locale language: remove lib universal_html
…ed on 'String?' because it is potentially null.
…y: npx eslint . --fix
…e is the same locale langugae, no display translation
317e102
to
fd7702b
Compare
…o improve performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.