Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove network check from bootstrapping calls to prevent startup race condition #265

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Remove network check from bootstrapping calls to prevent startup race condition #265

merged 1 commit into from
Feb 18, 2025

Conversation

jhaven-stytch
Copy link
Contributor

Linear Ticket: None

Changes:

  1. Remove the network sanity check when refreshing bootstrap data. Since we standardized on an "off by default" value, it was possible that the network didn't report it's status before the initial bootstrap call, and thus calls before it did so would use incorrect bootstrap data.

Notes:

Checklist:

  • I have verified that this change works in the relevant demo app, or N/A
  • I have added or updated any tests relevant to this change, or N/A
  • I have updated any relevant README files for this change, or N/A

@jhaven-stytch jhaven-stytch requested a review from a team as a code owner February 18, 2025 17:47
@jhaven-stytch jhaven-stytch merged commit 25b21c8 into main Feb 18, 2025
4 checks passed
@jhaven-stytch jhaven-stytch deleted the jordan/fix-potential-bootstrap-race-condition branch February 18, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-stytch alex-stytch alex-stytch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhaven-stytch @alex-stytch