SDK-2372 Update B2B UI component ordering #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhaven-stytch
requested review from
alex-stytch and
nidal-stytch
and removed request for
alex-stytch
Comment on lines
135
to
136
| ProductComponent.OAuthButtons, | ||
| ProductComponent.SSOButtons, |
There was a problem hiding this comment.
We don't actually require OAuth and SSO to be next to each other--we just don't add any extra padding between the two sections if they're consecutive.
There was a problem hiding this comment.
Hmm, did I misremember that discussion?? Let me rethink on this then
There was a problem hiding this comment.
Ok, removed the button re-ordering. We're not adding any extra padding outside of the components, so all good
nidal-stytch
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear Ticket: SDK-2372
Changes:
Notes:
Checklist: